Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup AxiosError redundant message. #1795

Merged
merged 3 commits into from
Feb 26, 2023
Merged

Conversation

FledgeXu
Copy link
Contributor

Fix: #1792

@kelson42
Copy link
Collaborator

@FledgeXu Thank you!

Copy link
Contributor

@pavel-karatsiuba pavel-karatsiuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for cases of fully filled err response and if the error object is filled only partially.

@kelson42
Copy link
Collaborator

I would be OK to only unit test the cleanup function.

@FledgeXu
Copy link
Contributor Author

Ok, I will add it later.

@FledgeXu
Copy link
Contributor Author

FledgeXu commented Feb 24, 2023

I added a unit test case for cleanup function and I also adjusted the location of the function.

Copy link
Contributor

@pavel-karatsiuba pavel-karatsiuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Base: 70.40% // Head: 70.35% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (1150712) compared to base (0897042).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
- Coverage   70.40%   70.35%   -0.06%     
==========================================
  Files          23       23              
  Lines        2585     2587       +2     
  Branches      591      591              
==========================================
  Hits         1820     1820              
- Misses        659      661       +2     
  Partials      106      106              
Impacted Files Coverage Δ
src/util/misc.ts 72.35% <0.00%> (-0.68%) ⬇️
src/util/saveArticles.ts 81.34% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kelson42 kelson42 merged commit 8a1fbe1 into openzim:main Feb 26, 2023
@FledgeXu
Copy link
Contributor Author

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Axios Error in the log
3 participants