-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip html tags from title #1801
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1801 +/- ##
=======================================
Coverage 70.42% 70.42%
=======================================
Files 23 23
Lines 2597 2597
Branches 594 595 +1
=======================================
Hits 1829 1829
Misses 661 661
Partials 107 107
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a unit test for this and test the special cases.
src/util/misc.ts
Outdated
@@ -283,7 +283,7 @@ export function getStrippedTitleFromHtml(html: string) { | |||
const doc = domino.createDocument(html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm choqued by this line which is super CPU expensive. There is no way we coukd do that quicker?! I know this is not the topic of this PR, but stil...
tests added
Strip HTML tags from the title to avoid HTML tags in the search results
fix: #1797