Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove part of code which redirects the page #1811

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

pavel-karatsiuba
Copy link
Contributor

@pavel-karatsiuba pavel-karatsiuba commented Mar 17, 2023

Some Wikimedia sources return js with code that is not allowed to show pages in the iframe. This code makes an unexpected page redirect.
This PR replaced part of the code to avoid auto-redirect.

Fix: #1803

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: -0.27 ⚠️

Comparison is base (7f1fb44) 70.99% compared to head (01d3764) 70.72%.

❗ Current head 01d3764 differs from pull request most recent head ba1e1ec. Consider uploading reports for the commit ba1e1ec to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1811      +/-   ##
==========================================
- Coverage   70.99%   70.72%   -0.27%     
==========================================
  Files          23       23              
  Lines        2596     2593       -3     
  Branches      591      593       +2     
==========================================
- Hits         1843     1834       -9     
- Misses        648      653       +5     
- Partials      105      106       +1     
Impacted Files Coverage Δ
src/util/dump.ts 72.41% <69.23%> (-4.21%) ⬇️
src/util/const.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kelson42 kelson42 force-pushed the remove-redirect-code-from-js branch from 01d3764 to ba1e1ec Compare March 20, 2023 05:30
@kelson42 kelson42 merged commit 850b941 into main Mar 20, 2023
@kelson42 kelson42 deleted the remove-redirect-code-from-js branch March 20, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wiktionary archives since 2023-02 contain a redirect which breaks out of iframe
2 participants