Use the AWS SDK for JavaScript V3 #1851
Conversation
|
@manavg26 Thank you for your PR, look to the detailed log of the CI to understand why it fails. AFAIK there is at least linting problem. Look the command and start the linting locally and push when this is fixed. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1851 +/- ##
==========================================
- Coverage 71.42% 71.26% -0.17%
==========================================
Files 24 24
Lines 2625 2631 +6
Branches 595 594 -1
==========================================
Hits 1875 1875
- Misses 644 652 +8
+ Partials 106 104 -2
☔ View full report in Codecov by Sentry. |
|
@manavg26 For me the feature is broken, if I launch MWoffliner with S3 configuration I get: |
|
@manavg26 what about my last comment that it does not work for me (without th pr it works)? Do i need to change some5ing in my configuration? |
Have made some changes, can you check now? |
|
@manavg26 Still same failure. Do you have tested your code? With which ObjectStorage provider? To me if I read the error reporting it seems pretty clear what is the error. You see "Public IP used: [object Promise]" so it seems we have at least some kind of problem related to the IP detection. |
|
Transfering ownership of issue/PR revieing to @VadimKovalenkoSNF. At some point this has to be fixed/reviewed so we can avoid warning and soon outage because of S3 backend. Maybe this PR needs to be superseeded. |
| secretAccessKey: this.params.secretAccessKey, | ||
| s3ForcePathStyle: s3UrlBase.protocol === 'http:', | ||
| const s3UrlObj: any = new URL(this.url) | ||
| const regionRegex: RegExp = /^https?:\/\/s3\.([^.]+)\.amazonaws\.com/; |
There was a problem hiding this comment.
amazonaws is not a valid sub-domain for test purposes, there should be wasabisys instead. Also, It should be configurable and not present in the code.
| return true | ||
| } | ||
| } catch (err) { | ||
| throw new Error(`Unable to connect to S3, either S3 login credentials are wrong or bucket cannot be found |
There was a problem hiding this comment.
This error is not explicit enough, probably err.message should be used instead.
|
superseeded by #1865 |
migrated the code to the AWS SDK for JavaScript V3
Tag: manavg261840-aws-sdk-JSv3
Fixes #1840