Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better usage() #1996

Merged
merged 8 commits into from
Mar 5, 2024
Merged

Better usage() #1996

merged 8 commits into from
Mar 5, 2024

Conversation

kelson42
Copy link
Collaborator

Fixes #1983

@kelson42 kelson42 requested a review from benoit74 February 23, 2024 12:01
@kelson42 kelson42 changed the title Better usage Better usage() Feb 23, 2024
benoit74
benoit74 requested changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good overall, great.

As expected, everytime you read this again you find new ideas ^^ These are mostly suggestions

src/parameterList.ts Outdated Show resolved Hide resolved
src/parameterList.ts Outdated Show resolved Hide resolved
src/parameterList.ts Outdated Show resolved Hide resolved
src/parameterList.ts Outdated Show resolved Hide resolved
src/parameterList.ts Outdated Show resolved Hide resolved
src/parameterList.ts Outdated Show resolved Hide resolved
@kelson42 kelson42 requested a review from benoit74 March 1, 2024 07:45
benoit74
benoit74 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for, I let you decide what to do from the last conversation opened (and the failing CI, I don't know if this is "normal")

@kelson42 kelson42 merged commit b8f37dc into main Mar 5, 2024
2 of 3 checks passed
@kelson42 kelson42 deleted the better-usage branch March 5, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoit74 benoit74 benoit74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the README
2 participants
@kelson42 @benoit74