Always use fallback language strings, in case specified language is missing any keys #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@audiodude Does it fix #1998 to your opinion? |
Let me check real quick. |
I can't verify https://scn.vikidia.org/ because it is behind Cloudflare, so mwoffliner gets a 403 because it can't pass the CAPTCHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2046
The source of this bug is a missing
DISCLAIMERkey in https://github.com/openzim/mwoffliner/blob/main/translation/fi.json and similar missing fields inar.json.The current "fallback" logic of
getStringsForLangis that, if the requested language file is completely missing (reading the file throws an error), useen.This PR makes it so that the fallback (
enor whatever is specified) is used by default for all necessary strings, then specific strings that are available in a translation file override theenstrings.