Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly await async polyfill function to avoid race condition #2055

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

audiodude
Copy link
Member

Fixes #2054

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.88%. Comparing base (372f0c7) to head (dbff5d9).

Files Patch % Lines
src/mwoffliner.lib.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2055      +/-   ##
==========================================
+ Coverage   74.38%   74.88%   +0.50%     
==========================================
  Files          41       41              
  Lines        3146     3146              
  Branches      689      689              
==========================================
+ Hits         2340     2356      +16     
+ Misses        686      671      -15     
+ Partials      120      119       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@audiodude audiodude merged commit 4e572ac into main Jul 7, 2024
5 of 6 checks passed
@audiodude audiodude deleted the race-condition branch July 7, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Zim Creator being destroyed when fetching one article
1 participant