Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zimcheck returns errors: Broken links of favicon.ico #141

Closed
holta opened this issue May 22, 2022 · 4 comments · Fixed by #175
Closed

Zimcheck returns errors: Broken links of favicon.ico #141

holta opened this issue May 22, 2022 · 4 comments · Fixed by #175
Assignees
@pavel-karatsiuba
Labels
bug
Milestone
2.4.0

Comments

@holta
Copy link

holta commented May 22, 2022

I don't know if this is a bug report — or if this zimcheck failure is considered normal!?

Below is the output of zimcheck -U phet_en_2021-08.zim (which is the latest available from https://download.kiwix.org/zim/phet/).

[INFO] Checking zim file phet_en_2021-08.zim
[INFO] Zimcheck version is 3.1.1
[INFO] Verifying Articles' content...
[ERROR] Invalid internal links found:
  The following links:
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
(A/favicon.ico) were not found in article A/index.html
  The following links:
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
(A/favicon.ico) were not found in article A/template.html
[INFO] Overall Test Status: Fail
[INFO] Total time taken by zimcheck: <3 seconds.

The above returns error code 1, i.e. when you run echo $?

Here's the output of the full command zimcheck phet_en_2021-08.zim

[INFO] Checking zim file phet_en_2021-08.zim
[INFO] Zimcheck version is 3.1.1
[INFO] Verifying ZIM-archive structure integrity...
[INFO] Avoiding redundant checksum test (already performed by the integrity check).
[INFO] Searching for metadata entries...
[INFO] Searching for Favicon...
[INFO] Searching for main page...
[INFO] Verifying Articles' content...
[INFO] Searching for redundant articles...
  Verifying Similar Articles for redundancies...
[INFO] Checking for redirect loops...
[WARNING] Redundant data found:
  -/541648fd4f6aba4a4c571731279879a4.js and -/79f8a62169a34feb3a7b75d20d33cd46.js
  -/74e5aa2e805c18e33d234feeefc342ff.js and -/aa1095767d85577a3ffb3aa41629c2e7.js
  -/46f646de6501bcf55a6eab1b1a05e336.js and -/c1869d0e4563662a5565ef2e633b677f.js
  -/322674d5ef4d02beaf4b9ca77a812888.js and -/e084437505f75433b3aa5a69144a316d.js
  -/66538a7fc180ef67c41f94d61187b7ac.js and -/fd98f6543a12a0d71cdaf9abd90e7f84.js
  -/26d5c285abab22d3e2c139da755f963d.js and -/d0fe8e2cc44894533adc9f8ebc9deb88.js
  -/cad2e2a6600daa85bd12f36c675bb1bc.js and -/eda7b6871af29f23f9d4a74d8c4ba5d1.js
  -/97576631c5712bc3a6c6876b2f1f9e32.js and -/d6cde8823756bc314fda336add6ef3ce.js
  -/6646433e4b72fdd17f51efd7cac609f1.js and -/d94ecf59885c08dabe8ff932b97e9c37.js
  -/0d2532063866d6896cd25be5fdcd9ba0.js and -/723e318df67a6c7e5e5e64afe87f7fbe.js
  -/5a19f0840ea5ac6edda21ba40634a482.js and -/bdcee20c533416ab0b5e193e1334e81c.js
  -/231a960bf843fe4add5cbcd8303f158d.js and -/82430ce2ebb9adf9ca11a5b8f785af81.js
[ERROR] Invalid internal links found:
  The following links:
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
(A/favicon.ico) were not found in article A/index.html
  The following links:
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
- favicon.ico
(A/favicon.ico) were not found in article A/template.html
[INFO] Overall Test Status: Fail
[INFO] Total time taken by zimcheck: <3 seconds.

FYI here's the output of zimcheck --version

zim-tools 3.1.1

libzim 7.2.2
+ libzstd 1.5.2
+ liblzma 5.2.4
+ libxapian 1.4.18
+ libicu 58.2.0
@holta

This comment was marked as off-topic.

Sign in to view
@holta holta changed the title Should 'zimcheck phet_en_2021-08.zim' work without failures? (Is 'Invalid internal links found' serious?) Should 'zimcheck phet_en_2021-08.zim' work without failures? (Is 'Invalid internal links found' serious?) ⁠— ALSO: zimfarm is not posting to download.kiwix.org since Aug 2021 May 23, 2022
@kelson42

This comment was marked as off-topic.

Sign in to view
@kelson42

This comment was marked as off-topic.

Sign in to view
@kelson42 kelson42 added the bug label Nov 7, 2022
@kelson42 kelson42 changed the title Should 'zimcheck phet_en_2021-08.zim' work without failures? (Is 'Invalid internal links found' serious?) ⁠— ALSO: zimfarm is not posting to download.kiwix.org since Aug 2021 Alledged wrong links ot favicon.ico Nov 7, 2022
@kelson42 kelson42 added this to the 2.4.0 milestone Nov 7, 2022
@kelson42 kelson42 changed the title Alledged wrong links ot favicon.ico Zimcheck returns erros: Broken links ot favicon.ico Dec 4, 2022
@kelson42 kelson42 changed the title Zimcheck returns erros: Broken links ot favicon.ico Zimcheck returns errors: Broken links ot favicon.ico Dec 4, 2022
@kelson42
Copy link
Contributor

kelson42 commented Dec 4, 2022

Here the goal of the ticket should be:

@kelson42 kelson42 changed the title Zimcheck returns errors: Broken links ot favicon.ico Zimcheck returns errors: Broken links of favicon.ico Dec 4, 2022
@pavel-karatsiuba pavel-karatsiuba mentioned this issue Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavel-karatsiuba pavel-karatsiuba

Labels
bug
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Fixed (Favicon related) errors which returned by Zimcheck openzim/phet
3 participants
@kelson42 @holta @pavel-karatsiuba