Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing google-analytics script and meta OGP tags #153

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

pavel-karatsiuba
Copy link
Collaborator

Replacing inline JS's in HTML files was redesigned.

Fixes #127

@pavel-karatsiuba pavel-karatsiuba marked this pull request as ready for review November 30, 2022 11:55
@kelson42
Copy link
Contributor

kelson42 commented Nov 30, 2022

@pavel-karatsiuba It does not seem to remove the og:image meta tag to me. It does, sorry

@kelson42
Copy link
Contributor

@pavel-karatsiuba Ready to review?

@kelson42 kelson42 self-requested a review November 30, 2022 12:59
@kelson42 kelson42 changed the title Removing google-analitics script and meta OGP tags Removing google-analytics script and meta OGP tags Nov 30, 2022
Base automatically changed from issue-148-not-generating-zim to master December 1, 2022 18:56
@kelson42 kelson42 merged commit a9d155e into master Dec 1, 2022
@kelson42 kelson42 deleted the issue-127-remove-extra-tags branch December 1, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PhET experiments load Google Analytics script and other online content
2 participants