Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce scraper localization #183

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Introduce scraper localization #183

merged 3 commits into from
Dec 29, 2022

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented Dec 25, 2022 •
edited
Loading

Recreated from #178

@kelson42
Copy link
Contributor Author

After trying again, it seems that actually the scraper works fine if only part of the strings are available in fr.json (or any translation file). But I have discovered other problems:

  • If a json is not valid, the process should die (it does not for the moment)
  • ZIM metadata have been changed but are wrong.
    image

@kelson42 kelson42 changed the title Issue 85 scraper localization Introduce scraper localization Dec 28, 2022
@kelson42
Copy link
Contributor Author

@pavel-karatsiuba I had a look again to that PR. Thank you for the fixes. Here a few things left to do:

  • Please remove the "zim-creator", I want to keep that in one (english) version

All the rest looks good. But reviewing this PR, i came to the conclusion that we should use this PR to really improve slightly the sizes and position of the test for
image
Here the logo is far too big (whould be only slightly bigger in height than the two lines, the title should be horizontally centered to the middle of the logo. Finally the subtitle is really too small.

and
image

Here the white overlay seems far to big in width, the title should not be sticked to the top, overall margins should there, the description font size is too small and the text in the two button seems slightly too small as well.

Maybe you want to fix these last remarks in another PR, I would understand it, otherwise feel free to make the fix here.

Then we will be good to merge

@pavel-karatsiuba pavel-karatsiuba force-pushed the issue-85-scraper-localization branch 3 times, most recently from 1539664 to a88f781 Compare December 29, 2022 10:01
@pavel-karatsiuba
issue#85
0497f5f 
Scraper localization using banana-i18n

Tests were fixed because HTML moved from the base template to the corresponding file.

Set En for default language.
If translations file not found then use default language.
If the translations file contains the wrong JSON then the process stops with an error.

npm ci fixed

styles fixes.
Main page title moved vertically to the middle of the logo.
Main page subtitle is smaller.
Text size of the buttons Load and Cancel changed
@kelson42
Copy link
Contributor Author

@Abijeet @translatewiki @Nikerabbit Could you please support this repository (within the Kiwix project)?

@Nikerabbit
Copy link

Can you to create a task in our Phabricator following the instructions in https://translatewiki.net/wiki/Translating:New_project? We will look into it after the holidays.

@pavel-karatsiuba
issue#85
72bc1d0 
styles fixes.
Removed unused css and fonts.
Loading Simulation window restyled.
@pavel-karatsiuba
issue#85
8523c97 
styles fixes.
return fonts because it uses for create zim file
@kelson42 kelson42 merged commit 2a7b053 into main Dec 29, 2022
@kelson42 kelson42 deleted the issue-85-scraper-localization branch December 29, 2022 17:53
@kelson42
Copy link
Contributor Author

Made at https://phabricator.wikimedia.org/T326040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelson42 @Nikerabbit @pavel-karatsiuba