Issue 155: log metadata prior to verification (PR #160 fixes) #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
reviewed
Jun 21, 2024
There was a problem hiding this comment.
I feel like it is indeed way simpler to read for maintainers. Less open to later modifications, but as already said this would be premature optimization from my PoV.
I just have one small question about one log message from not decodable metadata, I feel like we should be more explicit.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 1412 1439 +27
Branches 243 248 +5
=========================================
+ Hits 1412 1439 +27 ☔ View full report in Codecov by Sentry. |
benoit74
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
LGTM, I just squashed the commits and edited the commit message. Commit is still attributed to @richterdavid which is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't push on #160 so here's a copy of it with my fixes at the end.
Should it be satisfactory, I suggest we squash all commits into one.
Fixes #155