-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata length validation: count graphemes #176
Conversation
8a3d822
to
34a1192
Compare
Edit: also had to add commit using Jeena instance just like in #175 to let the CI pass |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 1448 1452 +4
Branches 251 251
=========================================
+ Hits 1448 1452 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ; please check suggestion/comment
Requested changes applied, beware I did a |
Fix #158
Fix #177
Changes
regex
module to count graphemes, it looks like the most stable and maintained package for our needgrapheme_count
so that it can be easily reused + fixed in the future if needed