Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes for mindtouch #213

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Small changes for mindtouch #213

merged 2 commits into from
Nov 8, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Nov 8, 2024

Very simplified version of #211 since for now decided not to include an executor but rely on joblib (or another parallel processing lib) for now.

Changes:

  • fix few type hints to be more precise
  • add standard log format for displaying threads info

@benoit74 benoit74 self-assigned this Nov 8, 2024
@benoit74 benoit74 changed the title Small changes for parallel processing Small changes for mindtouch Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7b41b04) to head (f5f0412).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #213   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         2223      2224    +1     
  Branches       426       426           
=========================================
+ Hits          2223      2224    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review November 8, 2024 13:05
@benoit74 benoit74 requested a review from rgaudin November 8, 2024 13:06
@benoit74 benoit74 merged commit e89899c into main Nov 8, 2024
9 checks passed
@benoit74 benoit74 deleted the small_changes branch November 8, 2024 14:55
@benoit74 benoit74 added this to the 5.0.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants