Skip to content

Conversation

@elfkuzco
Copy link
Contributor

Rationale

Sometimes, it is necessary to fail quickly on http errors or connection timeouts rather than the default. By adding the options to set the configuration values as params, users can set their desired configuration values. One such beneficiary would be the zimfarm where KiwixStorage is used for Wasabi operations openzim/zimfarm#863

Changes

  • add http timeout configuration parameters to KiwixStorage class

@elfkuzco elfkuzco requested a review from rgaudin September 22, 2025 13:10
@elfkuzco
Copy link
Contributor Author

squashed into one commit

@elfkuzco elfkuzco requested a review from benoit74 September 23, 2025 09:15
Copy link
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 13886e1 into openzim:main Sep 25, 2025
1 check passed
@benoit74 benoit74 added this to the 0.9.1 milestone Sep 25, 2025
@benoit74 benoit74 mentioned this pull request Sep 25, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants