Update dependencies #281
Merged
Update dependencies #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested the |
FledgeXu
force-pushed
the
bummp-up-version
branch
from
edfac51 to
96e94a5
Compare
rgaudin
reviewed
Mar 6, 2023
requirements.txt
Outdated
| @@ -1,19 +1,19 @@ | |||
| kiwixstorage>=0.8.1,<1.0 | |||
| pif>=0.8.2,<0.9 | |||
| zimscraperlib>=1.8.0,<1.9 | |||
| zimscraperlib>=2.0,<2.9 | |||
There was a problem hiding this comment.
I will fix it than.
requirements.txt
Outdated
| tld>=0.12.6,<0.13 | ||
| mistune>=2.0.0rc1,<2.1 | ||
| tld>=0.13,<0.14 | ||
| mistune>=3.0.0rc4,<3.1 |
There was a problem hiding this comment.
No. There's no changelog so definitely not upgrading to a new major, rc. Requires extensive tests.
There was a problem hiding this comment.
@rgaudin You mean we don’t need to update tld and mistune, those two packages?
There was a problem hiding this comment.
No tld is fine but mistune's new version is to the next major version while it is somewhat critical. Given there's no changelog to look at differences, let's keep it in 2.x
|
I update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #279
This PR may need some tests before it's merged.