Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetching topics, moved to an internal search API #151

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Dec 14, 2023

Fix #149

Changes

  • move to an internal search API to find videos per topic
  • enhance the utility method download_link to also perform POST requests needed by the search
  • rewrite the filtering by language now that it is not available at search-time anymore when searching by topic
  • topic names must not be URL-escaped anymore
  • explicitly use the URL path to deduplicate videos (used only for playlists now)

Nota: code quality is obviously not optimal, I will fix it all at once with #148 which will be done right after this is merged.

@benoit74 benoit74 marked this pull request as ready for review December 14, 2023 15:16
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ; please add a docstring to request_url since it now has two behaviors and we're good to merge.

ted2zim/constants.py Show resolved Hide resolved
@benoit74 benoit74 merged commit 9eae1dc into main Dec 18, 2023
1 check passed
@benoit74 benoit74 deleted the fix_topics branch December 18, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TED recipes based on --topics are not working anymore
2 participants