Allow to specify a scraper suffix for the ZIM scraper metadata at the CLI #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
force-pushed
the
scraper_suffix
branch
from
f963080
to
9ae1021
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## warc2zim2 #168 +/- ##
=============================================
+ Coverage 86.52% 86.55% +0.03%
=============================================
Files 13 13
Lines 846 848 +2
Branches 147 147
=============================================
+ Hits 732 734 +2
Misses 97 97
Partials 17 17 ☔ View full report in Codecov by Sentry. |
benoit74
force-pushed
the
scraper_suffix
branch
from
9ae1021
to
43e9843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #156
Nota: also updates the version to
dev1as agreed in issue.