Ignore resource
WARC records for now
#198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #197
add_items_for_warc_record
is already called only for records of typeresource
,response
andrevisit
(i.e.request
records are ignored) due to the filtering logic ofiter_warc_records
.The logic to add a real item to the ZIM was not called if record type is
revisit
, i.e. it was called only forresource
andresponse
.As explained in #197,
resource
WARC records must not be added as-is to the ZIM, they are not regular web responses (as their WARC type implies).The logic is hence inverted to also be future-prood:
response
revisit