Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inclusion of custom CSS in warc2zim2 #264

Merged
merged 2 commits into from
May 21, 2024
Merged

Fix inclusion of custom CSS in warc2zim2 #264

merged 2 commits into from
May 21, 2024

Commits on May 21, 2024

  1. Fix and simplify custom CSS injection 

    - pass the CSS as stuff to be rendered (we need to compute the relative
  ZIM path based on current page location)
- directly create a ZIM record instead of faking a WARC record
  (simplification and less error-prone)
- store custom CSS at `_zim_static/custom.css` instead of magic URL `warc2zim.kiwix.app/custom.css`
    @benoit74
    benoit74 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1c38fe6 View commit details
    Browse the repository at this point in the history

  2. Do not log issues about encoding when only concern is that no content… 

    …-type was passed in HTTP headers
    @benoit74
    benoit74 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    57e0de7 View commit details
    Browse the repository at this point in the history