Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate ZIM metadata early #266

Merged
merged 1 commit into from
May 24, 2024
Merged

Validate ZIM metadata early #266

merged 1 commit into from
May 24, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented May 21, 2024 •
edited
Loading

Fix #235

Changes:

  • Validate title, description, long_description and tags early, including during the pre-check call from zimit
  • Add --disable-metadata-check CLI argument, not intended to be exposed in Zimfarm

@benoit74 benoit74 self-assigned this May 21, 2024
@benoit74 benoit74 changed the base branch from main to warc2zim2 May 21, 2024 11:55
@benoit74 benoit74 force-pushed the validate_metadata_early branch from fe2205f to d092cce Compare May 21, 2024 11:56
@benoit74 benoit74 marked this pull request as ready for review May 21, 2024 12:22
@benoit74 benoit74 mentioned this pull request May 21, 2024
Merged
@benoit74 benoit74 requested a review from rgaudin May 24, 2024 06:37
rgaudin
rgaudin approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 force-pushed the validate_metadata_early branch from d092cce to 44ed3bc Compare May 24, 2024 08:27
@benoit74 benoit74 merged commit 9cfdb40 into warc2zim2 May 24, 2024
4 checks passed
@benoit74 benoit74 deleted the validate_metadata_early branch May 24, 2024 08:30
@benoit74 benoit74 mentioned this pull request May 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate metadata as early as possible
2 participants
@benoit74 @rgaudin