Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for onxxx HTML events #270

Merged
merged 2 commits into from
May 24, 2024
Merged

Add support for onxxx HTML events #270

merged 2 commits into from
May 24, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented May 21, 2024

Fix #209

Changes:

@benoit74 benoit74 self-assigned this May 21, 2024
@benoit74 benoit74 changed the title Add suport for onxxx HTML events Add support for onxxx HTML events May 21, 2024
@benoit74 benoit74 marked this pull request as ready for review May 21, 2024 18:28
@benoit74 benoit74 requested a review from rgaudin May 21, 2024 18:29
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do we have a ticket for improving client side dynamic rewrite?
I know it's overkill at this point but there are ways like storing a sorted list of all entries paths that might be discussed in the future.

src/warc2zim/content_rewriting/html.py Outdated Show resolved Hide resolved
@benoit74
Copy link
Collaborator Author

Do we have a ticket for improving client side dynamic rewrite?

I just opened #276 ; I'm not sure it is a good idea to implement this, at least there are some drawbacks to discuss / find countermeasures.

@benoit74 benoit74 merged commit a98e6cf into warc2zim2 May 24, 2024
4 checks passed
@benoit74 benoit74 deleted the onxxx_events branch May 24, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants