Further enhance the situation regarding unknown encoding #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
force-pushed
the
charset_lookup_error
branch
from
87f03dd
to
9a4c9df
Compare
benoit74
force-pushed
the
charset_lookup_error
branch
from
a1f8655
to
ddbf74e
Compare
benoit74
force-pushed
the
charset_lookup_error
branch
from
a453766
to
646064f
Compare
|
For some reason, the CI was refusing to run. I created a new branch and PR and it was still the same. I suspect the problem is linked to the fact there was conflicting changes. I had to rebase to fix them, sorry for the force push. |
rgaudin
approved these changes
Aug 2, 2024
benoit74
force-pushed
the
charset_lookup_error
branch
from
646064f
to
ffcdfe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #331
Changes:
--encoding-aliasesargument to pass encoding/charset aliases