Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --withoutFTIndex (-j) option to zimrecreate tool #234

Closed
wants to merge 1 commit into from
Closed

Add --withoutFTIndex (-j) option to zimrecreate tool #234

wants to merge 1 commit into from

Conversation

data-man
Copy link
Contributor

No description provided.

@data-man
Copy link
Contributor Author

BTW, zim::writer::Creator extracts some Xapian's data to tmp-files even if indexing parameter == false.

@mgautierfr
Copy link
Collaborator

The option should be named "--noftindex".
It deactivate only the fulltext index, the title index (used for suggestion) is always created.

@data-man
Copy link
Contributor Author

The option should be named "--noftindex".

Ok.

do not create a full text index is the right description?

@data-man
Copy link
Contributor Author

the title index (used for suggestion) is always created.

How disable it?
I'm currently using libzim with with_xapian=false option for this.

@kelson42
Copy link
Contributor

@data-man @mgautierfr Should be like for zimwriterfs:

-j, --withoutFTIndex	don't create and add a fulltext index of the content to the ZIM.

@data-man
Copy link
Contributor Author

-j, --withoutFTIndex

Done.

@data-man data-man changed the title Add --noindex option to zimrecreate tool Add --withoutFTIndex (-j) option to zimrecreate tool Apr 19, 2021
mgautierfr
mgautierfr requested changes Apr 21, 2021
View reviewed changes
src/zimrecreate.cpp Outdated Show resolved Hide resolved
@mgautierfr
Copy link
Collaborator

the title index (used for suggestion) is always created.

How disable it?
I'm currently using libzim with with_xapian=false option for this.

There is no way to do it for now.

@mgautierfr
Copy link
Collaborator

Please squash all your commits into one and we are good.

@data-man
Copy link
Contributor Author

github-close-pull-request-with-squash

No? :)

@kelson42
Copy link
Contributor

@data-man One commit in a merge commit != One commit without merge commit

@mgautierfr
Copy link
Collaborator

We don't squash the Pull request itself into master.
We always create a merge commit to clearly identify which commits are part of the PR.
There is no option in github to squash all commits in the PR into one but still create a merge commit.

@data-man
Copy link
Contributor Author

I hate git. :(

@mgautierfr
Copy link
Collaborator

I've tried to be smart and rebase your branch on top of the new master (after the merge of #237) and git was smarter than me.
I messed a bit with the history and github didn't detect the merge.
But it is merged and in master. I'm closing the PR.

@mgautierfr mgautierfr closed this Apr 21, 2021
@data-man
Copy link
Contributor Author

Thanks!

BTW What if use docopt also in zimrecreate?

@mgautierfr
Copy link
Collaborator

BTW What if use docopt also in zimrecreate?

Would be a good thing. I haven't mention it as it is not part of this PR. But if you want to change this you are welcomed.

@data-man
Copy link
Contributor Author

But if you want to change this you are welcomed.

Ok, I'll do!

@data-man data-man deleted the zimrecreate_noindex_option branch October 23, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgautierfr mgautierfr mgautierfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@data-man @mgautierfr @kelson42