Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zimcheck: Test if the link is empty before testing its content. #280

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

mgautierfr
Copy link
Collaborator

Fix #279

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #280 (04dedc6) into master (a26a450) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   51.13%   51.13%           
=======================================
  Files          21       21           
  Lines        1936     1936           
  Branches     1145     1146    +1     
=======================================
  Hits          990      990           
  Misses        944      944           
  Partials        2        2           
Impacted Files Coverage Δ
src/zimcheck/checks.cpp 97.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26a450...04dedc6. Read the comment docs.

@mgautierfr mgautierfr merged commit d8279fd into master Jan 13, 2022
@mgautierfr mgautierfr deleted the fix_check branch January 13, 2022 14:37
@kelson42 kelson42 modified the milestone: 3.1.0 Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zimcheck test link's content before testing if it is empty.
2 participants