Correctly print the mainpage with zimdump. #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mainpage stored in new zim files is now a redirection to the "real" mainpage. Let's resolve the redirect before printing the path. Fix openzim/libzim#674
Codecov Report
@@ Coverage Diff @@
## master openzim/libzim#293 +/- ##
=======================================
Coverage 51.18% 51.18%
=======================================
Files 21 21
Lines 1940 1940
Branches 1152 1152
=======================================
Hits 993 993
Misses 945 945
Partials 2 2
Continue to review full report at Codecov.
|
kelson42
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mainpage stored in new zim files is now a redirection to the "real"
mainpage. Let's resolve the redirect before printing the path.
Fix #294