-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respecting the --ns option in zimdump show #316
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
==========================================
- Coverage 27.93% 27.84% -0.09%
==========================================
Files 26 26
Lines 2585 2593 +8
Branches 1376 1381 +5
==========================================
Hits 722 722
- Misses 1376 1384 +8
Partials 487 487 ☔ View full report in Codecov by Sentry. |
835441f
to
f8f971a
Compare
This PR add the We can merge this PR anyway but not sure we should really close #315 |
f8f971a
to
9617b27
Compare
@mgautierfr We need to know what is in the ZIM file. For the moment we can't properly because the "removal" of namespaces has broken From a general POV, Libzim7 has introduced the idea that end-user visible content (so not the metadata, ...) would be "all" in the same namespace If I agree to abstract/hide this concept for end-user, I think I can pretty much say: I disagree to hide it from the ZIM tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veloman-yunkan Late, but this PR has not been abandoned!
I have tested:
$ zimdump show --ns=M --url=Name gutenberg_fa_all_2023-08.zim
Entry not found
I don't know if I do something wrong but to me, it seems to fail (at least with latest libzim).
In addition, I have remarked that basically all the --ns
options are broken. I would really like to have them working like announced and like they were. Today, I have basically lost more than one hour because - with zimdump
- I was not even able to know if a ZIM file has a fulltext index or not! This is problematic.
@kelson42 That's because of openzim/libzim#843 |
It is possible to fix |
Is the fix for openzim/libzim#843 would invalidate the fix of zimdump ? If no, we should fix zimdump without waiting for libzim IMO. |
I was under the wrong impression (again mislead by the docstring) that |
@veloman-yunkan I'm slightly lost about the status of this PR, but please let me know when this is ready to new functional review. |
5d0ff3d
to
a2c9fa5
Compare
Now fixed taking advantage of |
I will check from a user perspective. |
a2c9fa5
to
82412c5
Compare
Fixes #315