Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of SIP URI scheme #329

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Add support of SIP URI scheme #329

merged 1 commit into from
Feb 4, 2023

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented Feb 4, 2023

Fixes #328

@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Base: 44.21% // Head: 44.20% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (603ce2e) compared to base (51f7548).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   44.21%   44.20%   -0.02%     
==========================================
  Files          23       23              
  Lines        2370     2371       +1     
  Branches     1321     1321              
==========================================
  Hits         1048     1048              
- Misses       1306     1307       +1     
  Partials       16       16              
Impacted Files Coverage Δ
src/tools.cpp 86.18% <0.00%> (-0.32%) ⬇️
src/tools.h 35.71% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kelson42 kelson42 merged commit 9f0f7f7 into main Feb 4, 2023
@kelson42 kelson42 deleted the sip-uri-scheme branch February 4, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dont consider sip: protocol URL as internal
2 participants