-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: ZimMount #348
feature: ZimMount #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This first version seems good (well, it is a first version :) )
While we are here, I want to mention a important thing:
A zim file can contains this four entries:
foo
foo/
foo/index.hmtl
foo/bar.html
.
So we have two entries in the zim files that are also directory on the filesystem. We have to handle that correctly (ignore them ? Map them to something else ?) and not crash or hide children.
For now, we would create a foo
node with a index.
Then we would create ,
index.html
and bar.html
nodes in foo
node.
But as the foo
node has a index, it will be shown as a file on filesystem and other entries will be hidden.
I think this issue is the real challenge here. All the others are pretty technical.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 27.43% 0.00% -27.44%
==========================================
Files 26 20 -6
Lines 2544 1683 -861
Branches 1389 926 -463
==========================================
- Hits 698 0 -698
- Misses 1333 1683 +350
+ Partials 513 0 -513 ☔ View full report in Codecov by Sentry. |
I took a look at the implementation of zimdump, and to my understanding, it would dump the file I think I could try to implement the same behavior in zimmount. |
Current progress:
Not working:
For kiwix/overview#79