Adjust to number of captures in previous regex #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 27.52% 27.70% +0.17%
==========================================
Files 26 26
Lines 2521 2527 +6
Branches 1346 1349 +3
==========================================
+ Hits 694 700 +6
+ Misses 1356 1346 -10
- Partials 471 481 +10
☔ View full report in Codecov by Sentry. |
veloman-yunkan
requested changes
Jul 22, 2023
mgautierfr
force-pushed
the
fix_redirect_regex
branch
from
9225b40
to
7cc5e93
Compare
- Refactor code to move parsing code in `parse_redirectArticles`. - Add test.
This way, zim-tools is properly tested even if gtest is not available in the system. (This is what is done in libzim and libkiwix)
mgautierfr
force-pushed
the
fix_redirect_regex
branch
from
7cc5e93
to
3b58ff7
Compare
veloman-yunkan
requested changes
Jul 28, 2023
`(.+)` is a bit to greedy and matches `\t`.
mgautierfr
force-pushed
the
fix_redirect_regex
branch
from
3b58ff7
to
e4dc68e
Compare
|
@veloman-yunkan comment fixed. I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #359