Move to c++17. #368
Move to c++17. #368
Conversation
All our compilers should handle c++17. Let's move on.
There was a problem hiding this comment.
I did my best to review the changes carefully. To the best of my understanding the changes are limited to replacing a single character 1 with a single character 7. Despite the seemingly minor modification its impact can be very consequential due to the changes in the language specification of C++17 relative to C++11. In particular:
-
New rules concerning the order of evaluation. Some of those enhancements of the specification shrink the realm of undefined behavior, possibly breaking the functionality of working (though buggy) code that accidentally took advantage of a particular implementation by a compiler of the old gap in the language standard.
-
Removal of the increment operator for the
booltype. This can result in changed semantics of template metaprogramming code snippets relying on SFINAE. -
etc, and so on, ...
Therefore these changes must be thoroughly tested before they can be allowed into the next release.
P.S. 😄
All our compilers should handle c++17. Let's move on.
Following of openzim/libzim#819
Fix openzim/libzim#757