Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zimwriterfs and missing magic file. #374

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Fix zimwriterfs and missing magic file. #374

merged 5 commits into from
Oct 12, 2023

Conversation

mgautierfr
Copy link
Collaborator

Fix #371

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (e4440d1) 27.72% compared to head (109afe5) 27.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   27.72%   27.58%   -0.15%     
==========================================
  Files          26       26              
  Lines        2528     2541      +13     
  Branches     1349     1350       +1     
==========================================
  Hits          701      701              
- Misses       1346     1359      +13     
  Partials      481      481              
Files Coverage Δ
src/zimwriterfs/zimwriterfs.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I notice that parse_args was inside a try block and is not anymore.

@mgautierfr
Copy link
Collaborator Author

Yes. But for me it should not be in. I suspect a too "large" try block.
The try/catch is to catch error from the zim creation. parse_args has no reason to throw a exception.

@mgautierfr mgautierfr merged commit e08484d into main Oct 12, 2023
10 of 13 checks passed
@mgautierfr mgautierfr deleted the check_magic_file branch October 12, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants