[CHECK] Do not continue with other checks if integrity check fails. #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloman-yunkan
requested changes
Jun 11, 2024
mgautierfr
force-pushed
the
no_crash_on_corrupted
branch
2 times, most recently
from
7d7c551
to
6dad932
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
+ Coverage 26.98% 27.02% +0.03%
==========================================
Files 26 26
Lines 2453 2457 +4
Branches 1338 1340 +2
==========================================
+ Hits 662 664 +2
Misses 1304 1304
- Partials 487 489 +2 ☔ View full report in Codecov by Sentry. |
src/zimcheck/zimcheck.cpp
Outdated
| if(enabled_tests.isEnabled(TestType::INTEGRITY)) { | ||
| should_run_full_test = test_integrity(filename, error); | ||
| } else { | ||
| error.infoMsg("[WARNING] Integrity check is skipped. Any detected errors may in fact due to corrupted/invalid data."); |
There was a problem hiding this comment.
... in fact be due to ...
mgautierfr
force-pushed
the
no_crash_on_corrupted
branch
from
6dad932
to
24d85cb
Compare
It make no sense to check content in a zim archive if the zim archive itself is broken and we can't read it.
mgautierfr
force-pushed
the
no_crash_on_corrupted
branch
from
24d85cb
to
875e09a
Compare
|
Fixed. Directly merge if you agree. |
veloman-yunkan
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It make no sense to check content in a zim archive if the zim archive itself is broken and we can't read it.
Fix openzim/libzim#893