Do not try to add twice Illustration. #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Illustration is already added by `addIllustration` call. So we must skip the `Illustration_*` metadata. Fix #418
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
- Coverage 27.02% 27.01% -0.02%
==========================================
Files 26 26
Lines 2457 2458 +1
Branches 1340 1339 -1
==========================================
Hits 664 664
- Misses 1304 1305 +1
Partials 489 489 ☔ View full report in Codecov by Sentry. |
mgautierfr
force-pushed
the
fix_zimrecreate
branch
from
e6100ab
to
2d1bc89
Compare
veloman-yunkan
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Illustration is already added by
addIllustrationcall.So we must skip the
Illustration_*metadata.Fix #418