Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresch a bit the 'packages' CI/CD with latest version of actions/distrib #424

Merged
merged 9 commits into from
Aug 24, 2024

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented Aug 24, 2024

  • Refresh a bit the configuration
  • Add ubuntu-moble to CI/CD
  • Add the latest Debian to the CI
  • Remove old zimwriter deb package

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.01%. Comparing base (fab5063) to head (304c458).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   27.01%   27.01%           
=======================================
  Files          26       26           
  Lines        2458     2458           
  Branches     1339     1339           
=======================================
  Hits          664      664           
  Misses       1305     1305           
  Partials      489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 changed the title Update a bit the actions Refresch a bit the 'packages' CI/CD with latest version of actions/distrib Aug 24, 2024
@kelson42
Copy link
Contributor Author

Maybe @tusharpm you can have a look to that PR and you have a few feedbacks?

.github/workflows/package.yml Outdated Show resolved Hide resolved
debian/zim-tools.install Outdated Show resolved Hide resolved
@kelson42
Copy link
Contributor Author

@tusharpm Do you know why we have this error on Ubuntu packages? For Debian, I guess it fails because - like you said - packages are not updated upstream in Debian repositories (ping @legoktm)

@kelson42 kelson42 marked this pull request as ready for review August 24, 2024 17:56
@kelson42
Copy link
Contributor Author

@tusharpm So, finally it seems the zim-tools.install file was really not necessary. I have removed it and now the Ubuntu deb files seem OK. But the Debian deb file still fail to build because libzim 9.2 has not been upload or not available at all. @legoktm or @tusharpm Are you able to help with this last problem?

@kelson42 kelson42 requested review from tusharpm and legoktm and removed request for tusharpm August 24, 2024 17:58
@kelson42 kelson42 added this to the 3.5.0 milestone Aug 24, 2024
@tusharpm
Copy link

tusharpm commented Aug 24, 2024

@tusharpm So, finally it seems the zim-tools.install file was really not necessary. I have removed it and now the Ubuntu deb files seem OK.

Nice catch! I don't know whether this impacts the output deb file in any way. I'll try spinning up a docker container and test them from the launchpad PPA.

But the Debian deb file still fail to build because libzim 9.2 has not been upload or not available at all. @legoktm or @tusharpm Are you able to help with this last problem?

Sadly, I'm not a Debian package maintainer. I'll defer to @legoktm for comment on updating the Debian pacakages.

Meanwhile, I suggest to continue using the previous (available) version of libzim if it doesn't have a major drawback/security vulnerability.

@kelson42
Copy link
Contributor Author

But the Debian deb file still fail to build because libzim 9.2 has not been upload or not available at all. @legoktm or @tusharpm Are you able to help with this last problem?

Sadly, I'm not a Debian package maintainer. I'll defer to @legoktm for comment on updating the Debian pacakages.

Meanwhile, I suggest to continue using the previous (available) version of libzim if it doesn't have a major drawback/security vulnerability.

This version of libzim relies on libzim 9.2, there is nothing I believe I can do about that. For the rest I kind of believe that @legoktm would be kind of consider to have a deputy, so don't be shy and ask him if you want and believe you have enough skills. For Kiwix this would be great, because it is not rare that @legoktm lack of time.

@kelson42 kelson42 merged commit b6fe360 into main Aug 24, 2024
11 of 15 checks passed
@kelson42 kelson42 deleted the more-ppa-upload branch August 24, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants