Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce MS Windows CI #425

Merged
merged 10 commits into from
Sep 2, 2024
Merged

Introduce MS Windows CI #425

merged 10 commits into from
Sep 2, 2024

Commits on Sep 2, 2024

  1. Add Windows CI. 

    Compilation of zim-tools is broken on Windows.
But let's setup the CI to validate the PR.
    @mgautierfr @kelson42
    mgautierfr authored and kelson42 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    df5032f View commit details
    Browse the repository at this point in the history

  2. Correctly compile tests if build without writer (on Windows)

    @mgautierfr @kelson42
    mgautierfr authored and kelson42 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    dcf0ca2 View commit details
    Browse the repository at this point in the history

  3. Do not set gcc specific option. 

    Meson already handle werror and wall, let's use it.
    @mgautierfr @kelson42
    mgautierfr authored and kelson42 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d6d67c2 View commit details
    Browse the repository at this point in the history

  4. ssize_t is not defined on Windows. 

    And anyway the argument is storing the output `std::string::size` which is a `size_t`
    @mgautierfr @kelson42
    mgautierfr authored and kelson42 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    72fabb3 View commit details
    Browse the repository at this point in the history

  5. Remove unused import of dirent.h

    @mgautierfr @kelson42
    mgautierfr authored and kelson42 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    37aa9ef View commit details
    Browse the repository at this point in the history

  6. Correctly convert char to unsigned char before calling isprint. 

    As specified in isprint documentation[1], it is undefined behavior if
input cannot represented as unsigned char.

Let's convert it as suggested in documentation.

[1] https://en.cppreference.com/w/cpp/string/byte/isprint
    @mgautierfr @kelson42
    mgautierfr authored and kelson42 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a124217 View commit details
    Browse the repository at this point in the history

  7. Fix getTextLength on Windows 

    As explained in comment, I don't know the root cause of all of this.

If you have an idea you are welcomed !!!!
    @mgautierfr @kelson42
    mgautierfr authored and kelson42 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d524aa8 View commit details
    Browse the repository at this point in the history

  8. Fix include of unistd.h on Windows

    @mgautierfr @kelson42
    mgautierfr authored and kelson42 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    7745ce7 View commit details
    Browse the repository at this point in the history

  9. Port zimcheck to docoptcpp 

    We don't have getopt on Windows.
Let's move command line parsing to docoptcpp as we already use it.

We lost parsing case insensitive options on the way.
    @mgautierfr @kelson42
    mgautierfr authored and kelson42 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    86315e0 View commit details
    Browse the repository at this point in the history

  10. Support older version of docopt. 

    Older version of docopt doesn't define Options.

Let's define it using `using` syntax (as done in recent version of docoptcpp)
    @mgautierfr @kelson42
    mgautierfr authored and kelson42 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5a8c6df View commit details
    Browse the repository at this point in the history