Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back matomo - was forgotten - and make it activable on-demand, disabled in dev #78

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

benoit74
Copy link
Collaborator

Looks like we dropped something in the big upgrade ^^ (see kiwix/operations#261)

@benoit74 benoit74 self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.35%. Comparing base (33c54ea) to head (8be3262).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   46.35%   46.35%           
=======================================
  Files          10       10           
  Lines         384      384           
  Branches       43       43           
=======================================
  Hits          178      178           
  Misses        205      205           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 force-pushed the vue_matomo branch 4 times, most recently from 26bf4b4 to abe87b2 Compare September 23, 2024 11:13
@benoit74 benoit74 marked this pull request as ready for review September 23, 2024 11:20
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this gets enabled?

@benoit74
Copy link
Collaborator Author

As discussed live, this config.json is customized in served / sourced from the UI, served in the docker image, customized via a configmap. OK to merge.

@benoit74 benoit74 merged commit b032d6b into main Sep 24, 2024
7 checks passed
@benoit74 benoit74 deleted the vue_matomo branch September 24, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants