Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add donate button #84

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Add donate button #84

merged 1 commit into from
Oct 29, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #27

Nota: I'm not using the donorbox JS because it integrates badly with existing UI / prevent natural translations / prevent opening link in new tab/window (which is mostly mandatory in zimit frontend).

Screen.Recording.2024-10-29.at.16.04.16.mov

@Popolechien comments welcomed on UX side ; am I using the proper link ? https://kiwix.org/en/get-involved/#donate

@benoit74 benoit74 self-assigned this Oct 29, 2024
@benoit74 benoit74 requested a review from rgaudin October 29, 2024 15:12
@benoit74
Copy link
Collaborator Author

PS: I forgot to preview it in the screenshot, but obviously when switching to RTL languages the button is on the left of the screen

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.35%. Comparing base (00390cf) to head (0750d24).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   46.35%   46.35%           
=======================================
  Files          10       10           
  Lines         384      384           
  Branches       43       43           
=======================================
  Hits          178      178           
  Misses        205      205           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Popolechien
Copy link
Contributor

Link is correct. Thank you.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ui/src/App.vue Show resolved Hide resolved
@benoit74 benoit74 merged commit 6024037 into main Oct 29, 2024
7 checks passed
@benoit74 benoit74 deleted the donate_button branch October 29, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add donation prompt
3 participants