Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tar files in --warcs #370

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Add support for tar files in --warcs #370

merged 1 commit into from
Aug 12, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Aug 9, 2024

Fix #369

Nota: r mode on tarfile.open means "handle compression transparently": https://docs.python.org/fr/3/library/tarfile.html#tarfile.open

@benoit74 benoit74 self-assigned this Aug 9, 2024
@benoit74 benoit74 marked this pull request as ready for review August 9, 2024 09:25
@benoit74 benoit74 requested a review from rgaudin August 9, 2024 09:25
@benoit74
Copy link
Collaborator Author

benoit74 commented Aug 9, 2024

Just updated the usage to mention tar and tar.gz support

@benoit74
Copy link
Collaborator Author

@rgaudin can you have a look please?

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; sorry I missed the notification

@benoit74 benoit74 merged commit d0d0c6e into main Aug 12, 2024
5 checks passed
@benoit74 benoit74 deleted the add_warc_tar branch August 12, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for uncompressed tar archive in --warcs
2 participants