Skip to content

Commit

Permalink
Address review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
alintnersfdc committed Oct 12, 2021
1 parent d7d0890 commit 2730fed
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions brave/src/main/java/brave/Tracer.java
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,6 @@ public final Span joinSpan(TraceContext context) {
}
}

/** Returns an equivalent context if exists in the pending map */
PendingSpan getPendingSpan(TraceContext context) {
return pendingSpans.get(context);
}

/**
* Explicitly creates a child within an existing trace. The result will be have its parent ID set
* to the input's span ID. If a sampling decision has not yet been made, one will happen here.
Expand Down Expand Up @@ -377,7 +372,7 @@ public Span toSpan(TraceContext context) {

Span toSpan(@Nullable TraceContext parent, TraceContext context) {
// Re-use a pending span if present: This ensures reference consistency on Span.context()
PendingSpan pendingSpan = getPendingSpan(context);
PendingSpan pendingSpan = pendingSpans.get(context);
if (pendingSpan != null) {
if (isNoop(context)) return new NoopSpan(context);
return _toSpan(context, pendingSpan);
Expand Down

0 comments on commit 2730fed

Please sign in to comment.