Add missing BOM entries for Jakarta artifacts (jms, servlet) #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
commented
Feb 1, 2023
brave-bom/pom.xml
Outdated
| @@ -184,6 +184,11 @@ | |||
| <artifactId>brave-instrumentation-jms</artifactId> | |||
| <version>${project.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>${project.groupId}</groupId> | |||
| <artifactId>brave-instrumentation-jakarta-jms</artifactId> | |||
There was a problem hiding this comment.
Just noticed the inconsistency with naming here (100% my bad) :( we could probably rename + relocate, @jcchavezs @shakuzen what do you think folks?
There was a problem hiding this comment.
Probably better to relocate to jakarta-jms
There was a problem hiding this comment.
@jcchavezs done
[WARNING] The artifact io.zipkin.brave:brave-instrumentation-jakarta-jms:jar:5.15.1-SNAPSHOT has been relocated to io.zipkin.brave:brave-instrumentation-jms-jakarta:jar:5.15.1-SNAPSHOT
sorry about that folks, somehow sneaked in
reta
force-pushed
the
add.bom
branch
6 times, most recently
from
f78eb76 to
f92cd7a
Compare
Signed-off-by: Andriy Redko <drreta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing BOM entries for Jakarta artifacts (jms, servlet)