Adds support for org.mongodb:mongodb-driver-core v5 #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <adrian@tetrate.io>
reta
reviewed
Apr 10, 2024
reta
reviewed
Apr 10, 2024
| */ | ||
| private static MongoDBDriver findMongoDBDriver() { | ||
| try { | ||
| Method getHost = ServerAddress.class.getMethod("getHost"); |
There was a problem hiding this comment.
Not sure if it is worth the effort, but we could use MethodHandles instead of reflection (since this is what reflection is using in latest JDKs under the hood).
There was a problem hiding this comment.
I guess we can.. technically the old mongodb driver had a floor JRE of 1.6, but I don't think it is widely used enough in that config to matter. If someone complains, we can revert it.
reta
approved these changes
Apr 10, 2024
added 2 commits
April 10, 2024 08:40
Signed-off-by: Adrian Cole <adrian@tetrate.io>
|
thanks for the help @reta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the new org.mongodb:mongodb-driver-core v5 driver via the following:
Fixes #1430