Fixes ppc64le setup for Knative #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We missed one script in #19 which possibly was due to bad wording at its call site. This is a script that downloads the minirootfs for the given arch. It isn't actually minirootfs. Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
commented
Dec 4, 2023
| @@ -39,6 +41,9 @@ case ${arch} in | |||
| s390x* ) | |||
| arch=s390x | |||
| ;; | |||
| ppc64le* ) | |||
There was a problem hiding this comment.
this was the spot missed
|
|
||
| WORKDIR /code | ||
| # Conditions aren't supported in Dockerfile instructions, so we copy source even if it isn't used. | ||
| COPY --from=code /code/ . | ||
|
|
||
| # Alpine's minirootfs is mirrored and only 5MB. Build on demand instead of consuming docker.io pulls |
There was a problem hiding this comment.
perhaps this confused folks to think the file was a binary not a script.
|
re-pushed tag and verified $ docker buildx imagetools inspect ghcr.io/openzipkin/alpine:3.18.5
Name: ghcr.io/openzipkin/alpine:3.18.5
MediaType: application/vnd.docker.distribution.manifest.list.v2+json
Digest: sha256:96fef92ecb335d060f40bea3abfd2073abc2b308bd1a55fbe656c6c32844d310
Manifests:
Name: ghcr.io/openzipkin/alpine:3.18.5@sha256:7c43f5840cd0359826b9c822e97ee2bee3fe4767b91214d5bb401d7f74568187
MediaType: application/vnd.docker.distribution.manifest.v2+json
Platform: linux/amd64
Name: ghcr.io/openzipkin/alpine:3.18.5@sha256:3e23a654d870435e434bbb9ac342ffe8047ef3ae385ab55fccb8f058272e95dd
MediaType: application/vnd.docker.distribution.manifest.v2+json
Platform: linux/arm64
Name: ghcr.io/openzipkin/alpine:3.18.5@sha256:72395cb2ebab63005c7599beab48615881b5f9f6eed73dc19091a223b2bdb21e
MediaType: application/vnd.docker.distribution.manifest.v2+json
Platform: linux/ppc64le
Name: ghcr.io/openzipkin/alpine:3.18.5@sha256:483e17f38864615b079314347f645f3a5bcefe88fe44c228b4e976711efdfce0
MediaType: application/vnd.docker.distribution.manifest.v2+json
Platform: linux/s390x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed one script in
#19 which possibly was due to bad wording at its call site. This is a script that downloads the minirootfs for the given arch. It isn't actually minirootfs.
This also removes travis as it setup, but wasn't running and there was confusion about it. See openzipkin/zipkin#3608