Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to specify zipkin http path relative to host #80

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Adds ability to specify zipkin http path relative to host #80

merged 1 commit into from
Sep 2, 2020

Conversation

andystanton
Copy link
Contributor

No description provided.

@andystanton
Copy link
Contributor Author

I closed and reopened to retrigger the Travis build. The original error suggests an unreliable Kafka test, but this change does not touch any of the Kafka code or dependencies. I've raised #82 to investigate this.

Copy link
Collaborator

@crispywalrus crispywalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

as you say you haven't touched anything kafka so it's unlikely that your changes affected those tests. I have only seen broken tests when I've actually broken something. So I have some concern.

@codefromthecrypt codefromthecrypt merged commit 0197e96 into openzipkin:master Sep 2, 2020
@codefromthecrypt
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants