Ensure OpenSSL is available for GRPC/Netty. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinmdavis
reviewed
Jan 9, 2017
| @@ -20,6 +20,16 @@ | |||
| <groupId>io.zipkin.java</groupId> | |||
| <artifactId>zipkin-server</artifactId> | |||
| <version>${zipkin.version}</version> | |||
| <exclusions> | |||
There was a problem hiding this comment.
Can you add a comment about why we have to do this?
|
Sure.
|
kevinmdavis
approved these changes
Jan 9, 2017
|
very interesting copying some of my favorite spring brains @dsyer @wilkinsona |
|
looks like gRPC 1.4 fixes the need for this. is there a way we can verify and remove the tomcat obviation? If we could, it would make integration better googleapis/google-cloud-java#1958 |
bogdandrutu
pushed a commit
that referenced
this pull request
Oct 27, 2017
Tested manually as well as unit tests. See #19 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on class loading order (Mac vs. Linux, surefire vs. executable uber jar) OpenSSL was either available, either not. As result gRPC communication was broken (see #18).
The root cause is best described in netty/netty-tcnative#151. In short
org.apache.tomcat.jni.Librarywas not loading from netty-tcnative-boringssl-static-1.1.33.Fork23.jar, but rather from tomcat-embed-core-8.5.6.jar (brought by zipkin-server -> spring-boot-starter-tomcat transitive dependency) and tcnative was failing to load proper JNI library as result.cc @kevinmdavis @adriancole