Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-native example #6

Merged

Conversation

DanielMSchmidt
Copy link
Contributor

This is a better try of adding react-native as an example. It does not work as for the reasons disussed in openzipkin/zipkin-js#128

@DanielMSchmidt
Copy link
Contributor Author

@adriancole Sorry for the long delay between updated PRs, haven't had the time to look into these issues

@DanielMSchmidt
Copy link
Contributor Author

@adriancole I am not 100% sure this works now, I am currently experiencing that the zipkin UI shows me my serviceName and spanName, but I can not get it to show a single trace. I am a bit clueless actually how this is possible.

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Oct 28, 2017 via email

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Oct 28, 2017 via email

@codefromthecrypt
Copy link
Member

@DanielMSchmidt might be a wild goose chase, but here's what I'd blindly do...
first if you are seeing service names definitely spans are arriving, you've a trace. make your app print the trace ID then try to curl it like http://localhost:9411/api/v2/trace/that_id

if timestamps show incorrectly, look at the batchrecorder, you'll notice it uses time.js. maybe this isn't working right in react. remember I'm just guessing so don't immediately blame anything.

gonna hit the sack but keep us posted!

@codefromthecrypt
Copy link
Member

giving a try

@codefromthecrypt
Copy link
Member

bug upstream.. I'll fix. basically accidentally prevented the default service name 'unknown'

@codefromthecrypt codefromthecrypt merged commit 1888b98 into openzipkin:master Oct 29, 2017
@DanielMSchmidt
Copy link
Contributor Author

Wow, nice that your found that, awesome job!

@DanielMSchmidt DanielMSchmidt deleted the add-react-native-example branch October 29, 2017 06:24
@codefromthecrypt
Copy link
Member

codefromthecrypt commented Oct 29, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants