Supports dependency linking on single-host RPC spans #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Before, if a client span was a parent of a server span, linking wouldn't work.
codefromthecrypt
force-pushed
the
deps-singlehost
branch
from
073e875 to
fdbb6c3
Compare
|
merging bc this is blocking the simplejson thing (and generally useful towards single-host spans). Happy to accept any feedback post commit. |
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
Before, if a client span was a parent of a server span, linking wouldn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if a client span was a parent of a server span, linking wouldn't
work.
See #1480