Removes old nullable annotation and fixes problems caught with analyzer #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
force-pushed
the
analyze-nullable
branch
2 times, most recently
from
08a9e3a to
be0c4d5
Compare
This can't break anything at runtime because the nullable annotation removed was source retention. This makes Intellij Nullable analysis possible.
codefromthecrypt
force-pushed
the
analyze-nullable
branch
from
be0c4d5 to
d12c56b
Compare
codefromthecrypt
pushed a commit
that referenced
this pull request
Oct 14, 2017
Before, we optimized to drop our source-retention Nullable in favor of JSR 305. In doing so, we got null analysis from Intellij. However, in doing so, we entered a swamp of dependency conflicts, which started with OSGi (hence switch to service mix bundle) and now with Java 9 (conflict with apps using jax-ws. Since we are a core dependency, and particularly not a user-api, this change caused more problems than it fixed. Hence, this reverts to the safer model of using internal source-retention nullable (which allows things like AutoValue to work, but don't introduce any chance of runtime class conflicts). See #1703 See openzipkin/brave#451
codefromthecrypt
pushed a commit
that referenced
this pull request
Oct 14, 2017
Before, we optimized to drop our source-retention Nullable in favor of JSR 305. In doing so, we got null analysis from Intellij. However, in doing so, we entered a swamp of dependency conflicts, which started with OSGi (hence switch to service mix bundle) and now with Java 9 (conflict with apps using jax-ws. Since we are a core dependency, and particularly not a user-api, this change caused more problems than it fixed. Hence, this reverts to the safer model of using internal source-retention nullable (which allows things like AutoValue to work, but don't introduce any chance of runtime class conflicts). See #1703 See openzipkin/brave#451
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
…er (openzipkin#1703) This can't break anything at runtime because the nullable annotation removed was source retention. This makes Intellij Nullable analysis possible.
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
Before, we optimized to drop our source-retention Nullable in favor of JSR 305. In doing so, we got null analysis from Intellij. However, in doing so, we entered a swamp of dependency conflicts, which started with OSGi (hence switch to service mix bundle) and now with Java 9 (conflict with apps using jax-ws. Since we are a core dependency, and particularly not a user-api, this change caused more problems than it fixed. Hence, this reverts to the safer model of using internal source-retention nullable (which allows things like AutoValue to work, but don't introduce any chance of runtime class conflicts). See openzipkin#1703 See openzipkin/brave#451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can't break anything at runtime because the nullable annotation
removed was source retention. This makes Intellij Nullable analysis
possible.