updates to the latest test dependencies #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
commented
Dec 4, 2023
| @@ -113,7 +113,7 @@ int port() { | |||
| // mostly waiting for https://github.com/testcontainers/testcontainers-java/issues/3537 | |||
| static final class MySQLContainer extends GenericContainer<MySQLContainer> { | |||
| MySQLContainer() { | |||
| super(parse("ghcr.io/openzipkin/zipkin-mysql:2.23.2")); | |||
| super(parse("ghcr.io/openzipkin/zipkin-mysql:2.24.3")); | |||
There was a problem hiding this comment.
this moves to the last published docker tag (well ignoring the accidental v3 one..). Doing this gets the recent cut of test images, even though they are a bit behind still. I'll update those later.
There was a problem hiding this comment.
I refreshed these
|
depends on #3612 and while at it I will look at all the images before bumping this one out of draft |
Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
latest-test-deps
branch
from
3e5a0ea to
f4c1cf5
Compare
Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
commented
Dec 5, 2023
| @@ -91,7 +91,7 @@ class ServerIntegratedBenchmark { | |||
|
|
|||
There was a problem hiding this comment.
Note: this bench doesn't complete yet, but I can work on that in another PR. Good news is it at least runs on Apple Silicon now!
anuraaga
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.