Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Scripts, ESLint and testing packages #3659

Merged
merged 10 commits into from
Dec 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 23 additions & 33 deletions zipkin-lens/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2015-2020 The OpenZipkin Authors
* Copyright 2015-2023 The OpenZipkin Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
Expand All @@ -12,54 +12,44 @@
* the License.
*/
module.exports = {
extends: [
'airbnb-typescript',
'plugin:prettier/recommended',
'prettier/@typescript-eslint',
'prettier/react',
],
extends: ['plugin:prettier/recommended', 'react-app', 'react-app/jest'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

  • airbnb-typescript
  • prettier/@typescript-eslint
  • prettier/react

and extend react-scrtips eslint configs.

rules: {
'import/no-anonymous-default-export': 'off',
'import/prefer-default-export': 'off',
'react/jsx-filename-extension': [1, { extensions: ['.js', '.jsx', '.tsx'] }],
'react/jsx-props-no-spreading': 'off',
'react/no-array-index-key': 'off',
'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'warn',
'react/no-unescaped-entities': 'off',
'max-classes-per-file': 'off',
'no-console': 0,
'no-underscore-dangle': ['off'],
'no-continue': ['off'],
'prefer-destructuring': ['error', {
'AssignmentExpression': {array: false, object: false},
'VariableDeclarator': {array: true, object: true}
}]
},
parser: '@typescript-eslint/parser',
parserOptions: {
tsconfigRootDir: __dirname,
project: ['./tsconfig.json']
'prefer-destructuring': [
'error',
{
AssignmentExpression: { array: false, object: false },
VariableDeclarator: { array: true, object: true },
},
],
'react/jsx-filename-extension': [
1,
{ extensions: ['.js', '.jsx', '.tsx'] },
],
'react/jsx-props-no-spreading': 'off',
'react/no-array-index-key': 'off',
'react/no-unescaped-entities': 'off',
'react-hooks/exhaustive-deps': 'warn',
},
plugins: [
'@typescript-eslint',
'jest',
'react-hooks'
],
globals: {
fetch: false,
document: false
document: false,
},
env: {
browser: true,
jquery: true,
'jest/globals': true
},
overrides: [
{
files: ['**/*.tsx'],
rules: {
'react/prop-types': 'off'
}
}
]
'react/prop-types': 'off',
},
},
],
};
Loading
Loading