New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request without host throw exception #221

Merged

fedj merged 1 commit into openzipkin:master from sphinxy:http1.0_missing_host

Sep 17, 2018

Contributor

sphinxy commented Sep 17, 2018

The request without host throw exception. Tested with asp.net core middleware and http1.0 request.

8e73b3c partly fixed it, but UriHelper.GetDisplayUrl implicitly uses host too, so throwing NullReferenceException.

dotnet/aspnetcore#2718 is the root of problem, check for details.


          Request without host throw exception

fddf026

fedj merged commit e9f13e2 into openzipkin:master

Collaborator

fedj commented Sep 17, 2018

Thanks a lot for the clear context !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet